Replace List with LocalVector on Skeleton3D's bone transform update. #92164
+7
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokageItLab
approved these changes
May 20, 2024
akien-mga
reviewed
May 21, 2024
RandomShaper
approved these changes
May 21, 2024
AThousandShips
approved these changes
May 21, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along the lines of #91989, this is a CPU-oriented optimization around removing allocations from a hot path detected in Nuku Warriors that led to around 2000+ allocations per frame due to the usage of a linked list to do a pre-order traversal.
The alternative implementation is fairly minimal and reuses a LocalVector across frames. I'm coming up with a reliable way to benchmark these, but if @Calinou perhaps already has something that causes this same hot path to be hit, that could be ideal to prove the result in an open benchmark.
No behavior differences are expected.